Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 562303002: Don't force display the addUser button. Also, remove cancelAdduser. (Closed)

Created:
6 years, 3 months ago by Mike Lerman
Modified:
6 years, 3 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't force display the addUser button. Also, remove cancelAdduser. BUG=412754 Committed: https://crrev.com/81d302348beed094f26e2cd8b647266eac8ef534 Cr-Commit-Position: refs/heads/master@{#294518}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/resources/user_manager/control_bar.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/user_manager/control_bar.js View 2 chunks +0 lines, -4 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Mike Lerman
Hi Nikita, Can you review this little CL? Thanks! Mike
6 years, 3 months ago (2014-09-11 18:06:52 UTC) #2
Nikita (slow)
https://codereview.chromium.org/562303002/diff/1/chrome/browser/resources/user_manager/control_bar.js File chrome/browser/resources/user_manager/control_bar.js (left): https://codereview.chromium.org/562303002/diff/1/chrome/browser/resources/user_manager/control_bar.js#oldcode138 chrome/browser/resources/user_manager/control_bar.js:138: $('add-user-button').hidden = false; Where would add user button be ...
6 years, 3 months ago (2014-09-11 20:56:16 UTC) #3
Mike Lerman
https://codereview.chromium.org/562303002/diff/1/chrome/browser/resources/user_manager/control_bar.js File chrome/browser/resources/user_manager/control_bar.js (left): https://codereview.chromium.org/562303002/diff/1/chrome/browser/resources/user_manager/control_bar.js#oldcode138 chrome/browser/resources/user_manager/control_bar.js:138: $('add-user-button').hidden = false; On 2014/09/11 20:56:16, Nikita Kostylev wrote: ...
6 years, 3 months ago (2014-09-11 21:05:21 UTC) #4
Nikita (slow)
lgtm
6 years, 3 months ago (2014-09-11 22:04:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562303002/1
6 years, 3 months ago (2014-09-11 22:24:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 779a02fb61393bbde73a29ef73982527d307d7be
6 years, 3 months ago (2014-09-12 01:27:06 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 01:29:19 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/81d302348beed094f26e2cd8b647266eac8ef534
Cr-Commit-Position: refs/heads/master@{#294518}

Powered by Google App Engine
This is Rietveld 408576698