content/public/browser/web_contents_delegate.cc - Issue 562263002: Check media permissions through RenderFrameHostDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_delegate.cc

Issue 562263002: Check media permissions through RenderFrameHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render_frame_get_sources

Patch Set: Code review fixes + rebase. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/media_stream_ui_proxy.h ('K') | « content/public/browser/web_contents_delegate.h ('k') | extensions/browser/app_window/app_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents_delegate.cc

diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc

index 0028339ab638088d8d909e2b1ac17f88415cfb7e..d930aedd1fa4f0de705057562ac8f343ee1c2005 100644

--- a/content/public/browser/web_contents_delegate.cc

+++ b/content/public/browser/web_contents_delegate.cc

@@ -169,6 +169,15 @@ void WebContentsDelegate::RequestMediaAccessPermission(

scoped_ptr<MediaStreamUI>());

}

+bool WebContentsDelegate::CheckMediaAccessPermission(

+ WebContents* web_contents,

+ const GURL& security_origin,

+ MediaStreamType type) {

+ DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||

perkj_chrome 2014/09/15 12:06:25 Why are we ever getting here? Should this be NOTRE

Henrik Grunell 2014/09/15 13:45:17 Not all classes that implement WebContentsDelegate

+ type == MEDIA_DEVICE_VIDEO_CAPTURE);

+ return false;

bool WebContentsDelegate::RequestPpapiBrokerPermission(

WebContents* web_contents,

const GURL& url,