extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc - Issue 562263002: Check media permissions through RenderFrameHostDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

Issue 562263002: Check media permissions through RenderFrameHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render_frame_get_sources

Patch Set: git cl format. Don't blame me. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/extension_host_delegate.h ('K') | « extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h ('k') | extensions/shell/browser/media_capture_util.h » ('j') | extensions/shell/browser/media_capture_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

index 1ce7c289b0d90b6bba7849885f231ba79ea6c0fe..df4131fba6906ecf72fb41e312da10040152e107 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

@@ -18,4 +18,11 @@ WebViewPermissionHelperDelegate::WebViewPermissionHelperDelegate(

WebViewPermissionHelperDelegate::~WebViewPermissionHelperDelegate() {

}

+bool WebViewPermissionHelperDelegate::CheckMediaAccessPermission(

+ content::WebContents* source,

+ const GURL& security_origin,

+ content::MediaStreamType type) {

+ return false;

Yoyo Zhou 2014/09/12 18:30:40 I'm not sure why this would return false, so it's

Henrik Grunell 2014/09/15 11:33:48 The default implementation should be defensive for

} // namespace extensions