chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc - Issue 562263002: Check media permissions through RenderFrameHostDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

Issue 562263002: Check media permissions through RenderFrameHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render_frame_get_sources

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h ('k') | chrome/browser/media/media_capture_devices_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

index 3279b883352a0d4b662adb35c548fe158a5d6385..07d924c52cf28c7368b18b2f4a9568ea0af018c2 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

@@ -138,7 +138,18 @@ void ChromeWebViewPermissionHelperDelegate::RequestMediaAccessPermission(

false /* allowed_by_default */);

}

- void ChromeWebViewPermissionHelperDelegate::OnMediaPermissionResponse(

+bool ChromeWebViewPermissionHelperDelegate::CheckMediaAccessPermission(

+ content::WebContents* source,

+ const GURL& security_origin,

+ content::MediaStreamType type) {

+ return web_view_guest()

+ ->embedder_web_contents()

+ ->GetDelegate()

+ ->CheckMediaAccessPermission(

+ web_view_guest()->embedder_web_contents(), security_origin, type);

+void ChromeWebViewPermissionHelperDelegate::OnMediaPermissionResponse(

const content::MediaStreamRequest& request,

const content::MediaResponseCallback& callback,

bool allow,