Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: tools/perf/metrics/power.py

Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/webrtc.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/power.py
diff --git a/tools/perf/metrics/power.py b/tools/perf/metrics/power.py
index 2afe07c82fd5f8a259bf22875da2d5c9b735086c..0d10aa4c72fdf035acd8cdff973ec18175507d23 100644
--- a/tools/perf/metrics/power.py
+++ b/tools/perf/metrics/power.py
@@ -15,16 +15,15 @@
# System power draw while idle.
_quiescent_power_draw_mwh = 0
- def __init__(self, platform, quiescent_measurement_time_s=0):
+ def __init__(self, browser, quiescent_measurement_time_s=0):
"""PowerMetric Constructor.
Args:
- platform: platform object to use.
+ browser: browser object to use.
quiescent_measurement_time_s: time to measure quiescent power,
in seconds. 0 means don't measure quiescent power."""
super(PowerMetric, self).__init__()
- self._browser = None
- self._platform = platform
+ self._browser = browser
self._running = False
self._starting_cpu_stats = None
self._results = None
@@ -44,15 +43,16 @@
if not self._running:
return
self._running = False
- self._results = self._platform.StopMonitoringPower()
+ self._results = self._browser.platform.StopMonitoringPower()
if self._results: # StopMonitoringPower() can return None.
self._results['cpu_stats'] = (
_SubtractCpuStats(self._browser.cpu_stats, self._starting_cpu_stats))
def _MeasureQuiescentPower(self, measurement_time_s):
"""Measure quiescent power draw for the system."""
- if not self._platform.CanMonitorPower() or \
- self._platform.CanMeasurePerApplicationPower() or \
+ platform = self._browser.platform
+ if not platform.CanMonitorPower() or \
+ platform.CanMeasurePerApplicationPower() or \
not measurement_time_s:
return
@@ -60,16 +60,14 @@
if PowerMetric._quiescent_power_draw_mwh:
return
- self._platform.StartMonitoringPower(self._browser)
+ platform.StartMonitoringPower(self._browser)
time.sleep(measurement_time_s)
- power_results = self._platform.StopMonitoringPower()
+ power_results = platform.StopMonitoringPower()
PowerMetric._quiescent_power_draw_mwh = (
power_results.get('energy_consumption_mwh', 0))
def Start(self, _, tab):
- self._browser = tab.browser
-
- if not self._platform.CanMonitorPower():
+ if not tab.browser.platform.CanMonitorPower():
return
self._results = None
@@ -77,11 +75,11 @@
# This line invokes top a few times, call before starting power measurement.
self._starting_cpu_stats = self._browser.cpu_stats
- self._platform.StartMonitoringPower(self._browser)
+ self._browser.platform.StartMonitoringPower(self._browser)
self._running = True
def Stop(self, _, tab):
- if not self._platform.CanMonitorPower():
+ if not tab.browser.platform.CanMonitorPower():
return
self._StopInternal()
« no previous file with comments | « tools/perf/measurements/webrtc.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698