tools/perf/measurements/smoothness_unittest.py - Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness_unittest.py

Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smoothness_unittest.py

diff --git a/tools/perf/measurements/smoothness_unittest.py b/tools/perf/measurements/smoothness_unittest.py

index 534abad8fd68499d8a151422d5aa5632832beb0e..3075d4ec40ac85db683ddb89a4e77cd5a7142fc0 100644

--- a/tools/perf/measurements/smoothness_unittest.py

+++ b/tools/perf/measurements/smoothness_unittest.py

@@ -68,7 +68,7 @@

tab = FakeTab()

measurement = smoothness.Smoothness()

- measurement.WillStartBrowser(tab.browser.platform)

+ measurement.WillStartBrowser(tab.browser)

measurement.WillNavigateToPage(test_page, tab)

measurement.WillRunActions(test_page, tab)

@@ -166,8 +166,8 @@

class BuggyMeasurement(smoothness.Smoothness):

fake_power = None

# Inject fake power metric.

- def WillStartBrowser(self, platform):

- self.fake_power = self._power_metric = FakePowerMetric(platform)

+ def WillStartBrowser(self, browser):

+ self.fake_power = self._power_metric = FakePowerMetric(browser)

measurement = BuggyMeasurement()

try:

« no previous file with comments | « tools/perf/measurements/smoothness.py ('k') | tools/perf/measurements/tab_switching.py » ('j') | no next file with comments »