Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: tools/perf/measurements/smoothness.py

Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import power 5 from metrics import power
6 from measurements import smoothness_controller 6 from measurements import smoothness_controller
7 from telemetry.page import page_test 7 from telemetry.page import page_test
8 8
9 9
10 class Smoothness(page_test.PageTest): 10 class Smoothness(page_test.PageTest):
11 def __init__(self): 11 def __init__(self):
12 super(Smoothness, self).__init__('RunSmoothness') 12 super(Smoothness, self).__init__('RunSmoothness')
13 self._power_metric = None 13 self._power_metric = None
14 self._smoothness_controller = None 14 self._smoothness_controller = None
15 15
16 @classmethod 16 @classmethod
17 def CustomizeBrowserOptions(cls, options): 17 def CustomizeBrowserOptions(cls, options):
18 options.AppendExtraBrowserArgs('--enable-gpu-benchmarking') 18 options.AppendExtraBrowserArgs('--enable-gpu-benchmarking')
19 options.AppendExtraBrowserArgs('--touch-events=enabled') 19 options.AppendExtraBrowserArgs('--touch-events=enabled')
20 options.AppendExtraBrowserArgs('--running-performance-benchmark') 20 options.AppendExtraBrowserArgs('--running-performance-benchmark')
21 power.PowerMetric.CustomizeBrowserOptions(options) 21 power.PowerMetric.CustomizeBrowserOptions(options)
22 22
23 def WillStartBrowser(self, platform): 23 def WillStartBrowser(self, browser):
24 self._power_metric = power.PowerMetric(platform) 24 self._power_metric = power.PowerMetric(browser)
25 25
26 def WillNavigateToPage(self, page, tab): 26 def WillNavigateToPage(self, page, tab):
27 self._power_metric.Start(page, tab) 27 self._power_metric.Start(page, tab)
28 self._smoothness_controller = smoothness_controller.SmoothnessController() 28 self._smoothness_controller = smoothness_controller.SmoothnessController()
29 self._smoothness_controller.SetUp(page, tab) 29 self._smoothness_controller.SetUp(page, tab)
30 30
31 def WillRunActions(self, page, tab): 31 def WillRunActions(self, page, tab):
32 self._smoothness_controller.Start(tab) 32 self._smoothness_controller.Start(tab)
33 33
34 def DidRunActions(self, page, tab): 34 def DidRunActions(self, page, tab):
35 self._power_metric.Stop(page, tab) 35 self._power_metric.Stop(page, tab)
36 self._smoothness_controller.Stop(tab) 36 self._smoothness_controller.Stop(tab)
37 37
38 def ValidateAndMeasurePage(self, page, tab, results): 38 def ValidateAndMeasurePage(self, page, tab, results):
39 self._power_metric.AddResults(tab, results) 39 self._power_metric.AddResults(tab, results)
40 self._smoothness_controller.AddResults(tab, results) 40 self._smoothness_controller.AddResults(tab, results)
41 41
42 def CleanUpAfterPage(self, page, tab): 42 def CleanUpAfterPage(self, page, tab):
43 if self._power_metric: 43 if self._power_metric:
44 self._power_metric.Stop(page, tab) 44 self._power_metric.Stop(page, tab)
45 if self._smoothness_controller: 45 if self._smoothness_controller:
46 self._smoothness_controller.CleanUp(tab) 46 self._smoothness_controller.CleanUp(tab)
OLDNEW
« no previous file with comments | « tools/perf/measurements/page_cycler_unittest.py ('k') | tools/perf/measurements/smoothness_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698