Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/perf/benchmarks/kraken.py

Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/indexeddb_perf.py ('k') | tools/perf/benchmarks/octane.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Runs Mozilla's Kraken JavaScript benchmark.""" 5 """Runs Mozilla's Kraken JavaScript benchmark."""
6 6
7 import os 7 import os
8 8
9 from metrics import power 9 from metrics import power
10 from telemetry import benchmark 10 from telemetry import benchmark
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 66
67 67
68 class _KrakenMeasurement(page_test.PageTest): 68 class _KrakenMeasurement(page_test.PageTest):
69 def __init__(self): 69 def __init__(self):
70 super(_KrakenMeasurement, self).__init__() 70 super(_KrakenMeasurement, self).__init__()
71 self._power_metric = None 71 self._power_metric = None
72 72
73 def CustomizeBrowserOptions(self, options): 73 def CustomizeBrowserOptions(self, options):
74 power.PowerMetric.CustomizeBrowserOptions(options) 74 power.PowerMetric.CustomizeBrowserOptions(options)
75 75
76 def WillStartBrowser(self, platform): 76 def WillStartBrowser(self, browser):
77 self._power_metric = power.PowerMetric(platform) 77 self._power_metric = power.PowerMetric(browser)
78 78
79 def DidNavigateToPage(self, page, tab): 79 def DidNavigateToPage(self, page, tab):
80 self._power_metric.Start(page, tab) 80 self._power_metric.Start(page, tab)
81 81
82 def ValidateAndMeasurePage(self, page, tab, results): 82 def ValidateAndMeasurePage(self, page, tab, results):
83 tab.WaitForJavaScriptExpression( 83 tab.WaitForJavaScriptExpression(
84 'document.title.indexOf("Results") != -1', 700) 84 'document.title.indexOf("Results") != -1', 700)
85 tab.WaitForDocumentReadyStateToBeComplete() 85 tab.WaitForDocumentReadyStateToBeComplete()
86 86
87 self._power_metric.Stop(page, tab) 87 self._power_metric.Stop(page, tab)
(...skipping 26 matching lines...) Expand all
114 """Mozilla's Kraken JavaScript benchmark.""" 114 """Mozilla's Kraken JavaScript benchmark."""
115 test = _KrakenMeasurement 115 test = _KrakenMeasurement
116 116
117 def CreatePageSet(self, options): 117 def CreatePageSet(self, options):
118 ps = page_set.PageSet( 118 ps = page_set.PageSet(
119 archive_data_file='../page_sets/data/kraken.json', 119 archive_data_file='../page_sets/data/kraken.json',
120 file_path=os.path.abspath(__file__)) 120 file_path=os.path.abspath(__file__))
121 ps.AddPageWithDefaultRunNavigate( 121 ps.AddPageWithDefaultRunNavigate(
122 'http://krakenbenchmark.mozilla.org/kraken-1.1/driver.html') 122 'http://krakenbenchmark.mozilla.org/kraken-1.1/driver.html')
123 return ps 123 return ps
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/indexeddb_perf.py ('k') | tools/perf/benchmarks/octane.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698