Release resources properly from safe browsing incident reporting service.

Release resources properly from safe browsing incident reporting service.

Ignore the context for process-wide incidents when waiting for the most
recent download finder to complete. Otherwise the service holds on to
state needlessly.

BUG=413253
R=robertshield@chromium.org
NOTRY=true

Committed: https://crrev.com/8868b1d6217e86d003cbeef3f98c9f282d834cdf
Cr-Commit-Position: refs/heads/master@{#294412}

[robertshield, 2014-09-11 15:37:22]

lgtm

https://codereview.chromium.org/562223002/diff/1/chrome/browser/safe_browsing...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
(right):

https://codereview.chromium.org/562223002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:442:
return report_;
can you make this report_ != null, makes it explicit to a casual reader that
report_ isn't a bool.

[grt (UTC plus 2), 2014-09-11 15:50:01]

Thanks. I'll git cl land this after the requisite change lands and the tryjobs
on patch set 1 are green.

https://codereview.chromium.org/562223002/diff/1/chrome/browser/safe_browsing...
File
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
(right):

https://codereview.chromium.org/562223002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:442:
return report_;
On 2014/09/11 15:37:22, robertshield wrote:
> can you make this report_ != null, makes it explicit to a casual reader that
> report_ isn't a bool.

Done.

[grt (UTC plus 2), 2014-09-11 17:15:15]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2014-09-11 17:16:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/562223002/20001

[commit-bot: I haz the power, 2014-09-11 17:25:27]

Committed patchset #2 (id:20001) as 007f5ea0aa20eedac59efed9530a1e359d9c509f

[commit-bot: I haz the power, 2014-09-11 18:42:47]

Patchset 2 (id:??) landed as
https://crrev.com/8868b1d6217e86d003cbeef3f98c9f282d834cdf
Cr-Commit-Position: refs/heads/master@{#294412}