Issue 562203006: Re-include options page declaration for ChromeVox webstore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 562203006: Re-include options page declaration for ChromeVox webstore. (Closed)

Created:
6 years, 3 months ago by David Tseng

Modified:
6 years, 3 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr

Project:
chromium

Visibility:
Public.

More Reviews

Description

Re-include options page declaration for ChromeVox webstore. BUG=414408 Committed: https://crrev.com/abaa1bf6913757418bdfdb17c93cf99ba0afe767 Cr-Commit-Position: refs/heads/master@{#295110}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562203006/1

6 years, 3 months ago (2014-09-16 16:41:40 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as ef59cd3dc1bce50ebde0bb2bccc67649737b37be

6 years, 3 months ago (2014-09-16 18:38:03 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 18:39:27 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/abaa1bf6913757418bdfdb17c93cf99ba0afe767
Cr-Commit-Position: refs/heads/master@{#295110}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages