runtime/vm/intermediate_language.cc - Issue 562203005: Inline toDouble calls on mints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 562203005: Inline toDouble calls on mints (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language.cc

diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc

index 3c12e4b634c93d42b625ae5ea24682c3b68c5112..6c7d624178609c1fb5054b083e814df267e4405b 100644

--- a/runtime/vm/intermediate_language.cc

+++ b/runtime/vm/intermediate_language.cc

@@ -2629,9 +2629,6 @@ void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

MethodRecognizer::RecognizeKind(function());

int num_args_checked = 0;

switch (recognized_kind) {

- case MethodRecognizer::kDoubleFromInteger:

- num_args_checked = 1;

Florian Schneider 2014/09/17 11:15:32 Change this to 2 to make inlining of DoubleFromInt

Cutch 2014/09/18 16:39:49 Done.

- break;

case MethodRecognizer::kMathMin:

case MethodRecognizer::kMathMax:

num_args_checked = 2;