Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Issue 562203004: Avoid usage of temporary MachineOperatorBuilder. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Avoid usage of temporary MachineOperatorBuilder. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -33 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/change-lowering.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/representation-change.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/simplified-lowering.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-16 13:54:58 UTC) #1
titzer
lgtm
6 years, 3 months ago (2014-09-16 15:04:12 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-09-16 16:20:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698