Flush SimpleCache worker pool between all tests.

Flush SimpleCache worker pool between all tests.

This will prevent tests that utilize a SimpleCache from running into teardown leaks.

BUG=413688
Committed: https://crrev.com/80e53817d6d93c7d1136dd3feeb2d4275056360f
Cr-Commit-Position: refs/heads/master@{#296936}

[jkarlin, 2014-09-12 14:38:16]

jkarlin@chromium.org changed reviewers:
+ michaeln@chromium.org

[jkarlin, 2014-09-12 14:38:17]

Here is the followup on flushing the worker pool that we discussed.  Thanks!

[michaeln, 2014-09-12 19:52:39]

the code change lgtm, but something is up with the RecreateCacheOnDemand test?

[jkarlin, 2014-09-15 18:03:20]

On 2014/09/12 19:52:39, michaeln wrote:
> the code change lgtm, but something is up with the RecreateCacheOnDemand test?

The flake on RecreateCacheOnDemand is a serious concern.  I've not seen that
before and don't see any cases of it flaking on the flakiness dashboard.  Hmm.

[gavinp, 2014-09-15 18:16:29]

On 2014/09/15 18:03:20, jkarlin wrote:
> On 2014/09/12 19:52:39, michaeln wrote:
> > the code change lgtm, but something is up with the RecreateCacheOnDemand
test?
> 
> The flake on RecreateCacheOnDemand is a serious concern.  I've not seen that
> before and don't see any cases of it flaking on the flakiness dashboard.  Hmm.

First guess: Flushing the pool, then shutting down the worker pool can cause
multi-step operations to die midstream when they don't have a backend_ object
after completion of one of the tasks.

[jkarlin, 2014-09-15 18:32:10]

On 2014/09/15 18:16:29, gavinp wrote:
> On 2014/09/15 18:03:20, jkarlin wrote:
> > On 2014/09/12 19:52:39, michaeln wrote:
> > > the code change lgtm, but something is up with the RecreateCacheOnDemand
> test?
> > 
> > The flake on RecreateCacheOnDemand is a serious concern.  I've not seen that
> > before and don't see any cases of it flaking on the flakiness dashboard. 
Hmm.
> 
> First guess: Flushing the pool, then shutting down the worker pool can cause
> multi-step operations to die midstream when they don't have a backend_ object
> after completion of one of the tasks.

I believe that it only calls the new flush at destruction of the
TestBrowserThreadBundle (at the end of the test) but the flake is mid-test. 
This flake probably exists in trunk :(

[jkarlin, 2014-09-23 13:19:54]

On 2014/09/15 18:32:10, jkarlin wrote:
> On 2014/09/15 18:16:29, gavinp wrote:
> > On 2014/09/15 18:03:20, jkarlin wrote:
> > > On 2014/09/12 19:52:39, michaeln wrote:
> > > > the code change lgtm, but something is up with the RecreateCacheOnDemand
> > test?
> > > 
> > > The flake on RecreateCacheOnDemand is a serious concern.  I've not seen
that
> > > before and don't see any cases of it flaking on the flakiness dashboard. 
> Hmm.
> > 
> > First guess: Flushing the pool, then shutting down the worker pool can cause
> > multi-step operations to die midstream when they don't have a backend_
object
> > after completion of one of the tasks.
> 
> I believe that it only calls the new flush at destruction of the
> TestBrowserThreadBundle (at the end of the test) but the flake is mid-test. 
> This flake probably exists in trunk :(

Confirmed, the flake is not due to this CL.  See
https://code.google.com/p/chromium/issues/detail?id=413775#c2.

I'll land this and am digging into the flake.

[jkarlin, 2014-09-23 16:05:56]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-23 16:06:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/562203002/40001

[commit-bot: I haz the power, 2014-09-23 16:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 16:13:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jkarlin, 2014-09-23 17:39:30]

On 2014/09/23 16:13:07, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Whoops, need an owner for content/browser/

[jkarlin, 2014-09-23 17:39:57]

jkarlin@chromium.org changed reviewers:
+ jochen@chromium.org

[jkarlin, 2014-09-23 17:39:58]

jochen@chromium.org: Please review changes in content/browser/

[jkarlin, 2014-09-23 17:40:33]

On 2014/09/23 17:39:58, jkarlin wrote:
> mailto:jochen@chromium.org: Please review changes in content/browser/

Specifically, I just need OWNERS for browser_thread_impl.cc

Thanks!

[jochen (gone - plz use gerrit), 2014-09-24 20:02:15]

could you do this change as well, so we don't end up calling it from production
code accidentially?

otherwise lgtm

https://codereview.chromium.org/562203002/diff/40001/content/browser/browser_...
File content/browser/browser_thread_impl.cc (right):

https://codereview.chromium.org/562203002/diff/40001/content/browser/browser_...
content/browser/browser_thread_impl.cc:145: void
BrowserThreadImpl::FlushThreadPoolHelper() {
this method should be called FlushThreadPoolHelperForTesting

[jkarlin, 2014-09-26 11:57:06]

https://codereview.chromium.org/562203002/diff/40001/content/browser/browser_...
File content/browser/browser_thread_impl.cc (right):

https://codereview.chromium.org/562203002/diff/40001/content/browser/browser_...
content/browser/browser_thread_impl.cc:145: void
BrowserThreadImpl::FlushThreadPoolHelper() {
On 2014/09/24 20:02:15, jochen (slow for reviews) wrote:
> this method should be called FlushThreadPoolHelperForTesting

Done.

[jkarlin, 2014-09-26 13:16:07]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-26 13:17:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/562203002/60001

[commit-bot: I haz the power, 2014-09-26 14:32:51]

Committed patchset #4 (id:60001) as e2f74535c552b3145a52d29d6d967336230770b6

[commit-bot: I haz the power, 2014-09-26 14:33:48]

Patchset 4 (id:??) landed as
https://crrev.com/80e53817d6d93c7d1136dd3feeb2d4275056360f
Cr-Commit-Position: refs/heads/master@{#296936}