Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: src/trusted/plugin/npapi/plugin_npapi.cc

Issue 5622003: Restructure the structs/unions involved in SRPC argument passing. This will... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/plugin/method_map.cc ('k') | src/trusted/plugin/npapi/scriptable_impl_npapi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/plugin/npapi/plugin_npapi.cc
===================================================================
--- src/trusted/plugin/npapi/plugin_npapi.cc (revision 3898)
+++ src/trusted/plugin/npapi/plugin_npapi.cc (working copy)
@@ -54,11 +54,11 @@
bool UrlAsNaClDesc(void* obj, plugin::SrpcParams* params) {
NaClSrpcArg** ins = params->ins();
PLUGIN_PRINTF(("UrlAsNaClDesc (obj=%p, url=%s, callback=%p)\n",
- obj, ins[0]->u.sval.str, ins[1]->u.oval));
+ obj, ins[0]->arrays.str, ins[1]->arrays.oval));
plugin::Plugin* plugin = reinterpret_cast<plugin::Plugin*>(obj);
- const char* url = ins[0]->u.sval.str;
- NPObject* callback_obj = reinterpret_cast<NPObject*>(ins[1]->u.oval);
+ const char* url = ins[0]->arrays.str;
+ NPObject* callback_obj = reinterpret_cast<NPObject*>(ins[1]->arrays.oval);
plugin::UrlAsNaClDescNotify* callback =
new(std::nothrow) plugin::UrlAsNaClDescNotify(plugin, url, callback_obj);
@@ -559,7 +559,7 @@
return false;
}
args->plugin = InstanceIdentifierToNPP(plugin->instance_id());
- args->callback = reinterpret_cast<NPObject*>(params->ins()[0]->u.oval);
+ args->callback = reinterpret_cast<NPObject*>(params->ins()[0]->arrays.oval);
NPN_RetainObject(args->callback);
nacl::DescWrapper* socket = plugin->service_runtime_->async_receive_desc();
NaClDescRef(socket->desc());
« no previous file with comments | « src/trusted/plugin/method_map.cc ('k') | src/trusted/plugin/npapi/scriptable_impl_npapi.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698