Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 562173003: rendering_helper - Drop frames if the decoder cannot catch up. (Closed)

Created:
6 years, 3 months ago by Owen Lin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

rendering_helper - Drop frames if the decoder cannot catch up. Originally, we delayed the rendering and waited for the late coming frames. However, when play with audio, the late coming frame should be just dropped to keep the AV sync. So we change to drop a frame if it comes too late. BUG=411123 TEST=Run vda_unittest on peach_pit. Committed: https://crrev.com/6471a6bf42a061ebddf43665636e8f77c85c33b2 Cr-Commit-Position: refs/heads/master@{#294992}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M content/common/gpu/media/rendering_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 3 chunks +9 lines, -1 line 4 comments Download

Messages

Total messages: 11 (3 generated)
Owen Lin
PTAL. Thanks.
6 years, 3 months ago (2014-09-12 08:32:33 UTC) #2
Pawel Osciak
lgtm % nits Please change the description to explain the audio part, perhaps say that ...
6 years, 3 months ago (2014-09-15 14:09:34 UTC) #3
Owen Lin
https://chromiumcodereview.appspot.com/562173003/diff/1/content/common/gpu/media/rendering_helper.cc File content/common/gpu/media/rendering_helper.cc (right): https://chromiumcodereview.appspot.com/562173003/diff/1/content/common/gpu/media/rendering_helper.cc#newcode533 content/common/gpu/media/rendering_helper.cc:533: if (video->last_frame_rendered) On 2014/09/15 14:09:34, Pawel Osciak wrote: > ...
6 years, 3 months ago (2014-09-16 01:38:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562173003/1
6 years, 3 months ago (2014-09-16 01:40:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as bc8d44028b9c5dcbb9974af1b87af23e09f5a1c6
6 years, 3 months ago (2014-09-16 02:43:41 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6471a6bf42a061ebddf43665636e8f77c85c33b2 Cr-Commit-Position: refs/heads/master@{#294992}
6 years, 3 months ago (2014-09-16 02:45:09 UTC) #8
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/562173003/diff/1/content/common/gpu/media/rendering_helper.cc File content/common/gpu/media/rendering_helper.cc (right): https://codereview.chromium.org/562173003/diff/1/content/common/gpu/media/rendering_helper.cc#newcode402 content/common/gpu/media/rendering_helper.cc:402: --video->frames_to_drop; Is this frame dropping visible outside this code ...
6 years, 3 months ago (2014-09-16 19:10:39 UTC) #10
Owen Lin
6 years, 3 months ago (2014-09-17 02:48:36 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/562173003/diff/1/content/common/gpu/media/ren...
File content/common/gpu/media/rendering_helper.cc (right):

https://codereview.chromium.org/562173003/diff/1/content/common/gpu/media/ren...
content/common/gpu/media/rendering_helper.cc:402: --video->frames_to_drop;
On 2014/09/16 19:10:39, acolwell_leaving_chromium_9-23 wrote:
> Is this frame dropping visible outside this code in some way? Web applications
> need to be able to observe this via
HTMLVideoElement::webkitDroppedFrameCount()
> and VideoPlaybackQuality::droppedVideoFrame() so that they can adapt the
content
> downward to avoid overtaxing the decoder.

The code is only used in the vda_unittest. It won't affect others.

Powered by Google App Engine
This is Rietveld 408576698