Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 562153002: MIPS: Added CallInterfaceDescriptors to all code stubs. (Closed)

Created:
6 years, 3 months ago by balazs.kilvady
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Added CallInterfaceDescriptors to all code stubs. Port r23854 (3870059) Original commit message: Added CallInterfaceDescriptors to all code stubs. A handful of code stubs are too complex to be described this way, and they are encoded with the macro DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR(). Along the way: * allowed inheritance of CallInterfaceDescriptors. * Defined static Register methods for some of the new CallInterfaceDescriptors. We could go a lot further here, but it doesn't have to be done immediately. * Added Representation arrays to some CallInterfaceDescriptors, especially where future hydrogen versions of the stubs could benefit from this knowledge. BUG= R=dusan.milosavljevic@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=23872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -60 lines) Patch
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 6 chunks +7 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 3 chunks +30 lines, -21 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 6 chunks +7 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 3 chunks +30 lines, -21 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
balazs.kilvady
6 years, 3 months ago (2014-09-11 11:04:20 UTC) #2
dusmil.imgtec
LGTM.
6 years, 3 months ago (2014-09-11 12:11:22 UTC) #3
balazs.kilvady
6 years, 3 months ago (2014-09-11 12:13:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23872 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698