Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 562133002: mojo: java bindigns: add factory for InterfaceRequest that takes a client (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: java bindigns: add factory for InterfaceRequest that takes a client When cretaing an InterfaceRequest for an interface that have a client, there must be a way to provide the client implementation. R=ppi@chromium.org Committed: https://crrev.com/14755294fdb15b90dfc0b3653277a0a65b8250de Cr-Commit-Position: refs/heads/master@{#294593}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
qsr
6 years, 3 months ago (2014-09-11 10:54:37 UTC) #1
ppi
lgtm % nits, thanks https://codereview.chromium.org/562133002/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java (right): https://codereview.chromium.org/562133002/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java#newcode93 mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java:93: * Construct a new |InterfaceRequest| ...
6 years, 3 months ago (2014-09-12 13:07:56 UTC) #2
qsr
https://codereview.chromium.org/562133002/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java (right): https://codereview.chromium.org/562133002/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java#newcode93 mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceWithClient.java:93: * Construct a new |InterfaceRequest| for the interface. This ...
6 years, 3 months ago (2014-09-12 14:16:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562133002/20001
6 years, 3 months ago (2014-09-12 14:21:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 478f23a3af137f217bbf6638f86b2492dfd41efc
6 years, 3 months ago (2014-09-12 15:30:51 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 15:40:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/14755294fdb15b90dfc0b3653277a0a65b8250de
Cr-Commit-Position: refs/heads/master@{#294593}

Powered by Google App Engine
This is Rietveld 408576698