Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 562103002: Files.app: Split background.js (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Split background.js This patch splits the background.js into the 3 files (background_base.js, app_window_wrapper.js, background.js), extracting the common classes. This patch itself doesn't change any functionality, but the extracted files will be used in the separated audio player app in near future. BUG=375039 TEST=browser_test passes Committed: https://crrev.com/479878c12c436c0bec667483df29fe1f23b710a2 Cr-Commit-Position: refs/heads/master@{#294998}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix a typo #

Patch Set 3 : Remove audio player files from .grd (they are not covered by this patch) #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -395 lines) Patch
A ui/file_manager/file_manager/background/js/app_window_wrapper.js View 1 2 3 1 chunk +346 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/background.js View 1 2 3 11 chunks +25 lines, -377 lines 0 comments Download
A ui/file_manager/file_manager/background/js/background_base.js View 1 chunk +47 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 3 chunks +4 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 2 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 3 months ago (2014-09-11 09:34:51 UTC) #2
hirono
lgtm with a nit. https://codereview.chromium.org/562103002/diff/1/ui/file_manager/file_manager/background/js/background.js File ui/file_manager/file_manager/background/js/background.js (right): https://codereview.chromium.org/562103002/diff/1/ui/file_manager/file_manager/background/js/background.js#newcode477 ui/file_manager/file_manager/background/js/background.js:477: audioPlayer.eaunch(playlist, false, function(appWindow) { launch?
6 years, 3 months ago (2014-09-11 12:52:12 UTC) #3
yoshiki
Thanks! https://codereview.chromium.org/562103002/diff/1/ui/file_manager/file_manager/background/js/background.js File ui/file_manager/file_manager/background/js/background.js (right): https://codereview.chromium.org/562103002/diff/1/ui/file_manager/file_manager/background/js/background.js#newcode477 ui/file_manager/file_manager/background/js/background.js:477: audioPlayer.eaunch(playlist, false, function(appWindow) { On 2014/09/11 12:52:11, hirono ...
6 years, 3 months ago (2014-09-12 02:04:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562103002/20001
6 years, 3 months ago (2014-09-12 02:09:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13520)
6 years, 3 months ago (2014-09-12 02:31:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562103002/40001
6 years, 3 months ago (2014-09-12 08:27:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13596)
6 years, 3 months ago (2014-09-12 09:50:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562103002/40001
6 years, 3 months ago (2014-09-14 03:38:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/14066)
6 years, 3 months ago (2014-09-14 03:51:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562103002/60001
6 years, 3 months ago (2014-09-16 01:26:33 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001) as dd0d7a64b28b379c69f2830e1c6b02a39c4eefab
6 years, 3 months ago (2014-09-16 03:30:30 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/479878c12c436c0bec667483df29fe1f23b710a2 Cr-Commit-Position: refs/heads/master@{#294998}
6 years, 3 months ago (2014-09-16 03:32:05 UTC) #20
yoshiki
6 years, 3 months ago (2014-09-16 06:23:35 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/563743004/ by yoshiki@chromium.org.

The reason for reverting is: This patch breaks the test..

Powered by Google App Engine
This is Rietveld 408576698