Issue 56205: NULL check web_contents_ to prevent a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56205: NULL check web_contents_ to prevent a crash. (Closed)

Created:
11 years, 8 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

NULL check web_contents_ to prevent a crash. In the notification observer, web_contents_ can be set to NULL so check for a NULL web_contents_ in GetWindowTitle. All the other methods check web_contents_ before using it too. BUG=9672

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/jsmessage_box_handler_win.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages