Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 562033003: [Turbofan] Insert nops for lazy bailout patching, fix translation of literals. (Closed)

Created:
6 years, 3 months ago by Jarin
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[Turbofan] Insert nops for lazy bailout patching, fix translation of literals. The code for EnsureSpaceForLazyDeopt is taken from lithium-codegen-*. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24138

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -5 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 3 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 3 chunks +25 lines, -0 lines 0 comments Download
M src/compiler/code-generator.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 4 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 3 chunks +17 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 3 chunks +17 lines, -0 lines 0 comments Download
M test/mjsunit/regress/string-set-char-deopt.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please?
6 years, 3 months ago (2014-09-15 12:40:44 UTC) #2
Benedikt Meurer
LGTM with comment. https://codereview.chromium.org/562033003/diff/1/src/compiler/arm64/code-generator-arm64.cc File src/compiler/arm64/code-generator-arm64.cc (right): https://codereview.chromium.org/562033003/diff/1/src/compiler/arm64/code-generator-arm64.cc#newcode868 src/compiler/arm64/code-generator-arm64.cc:868: ptrdiff_t padding_size = last_lazy_deopt_pc_ + space_needed ...
6 years, 3 months ago (2014-09-22 07:23:37 UTC) #3
Jarin
6 years, 3 months ago (2014-09-23 08:46:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698