Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 562013003: Never run the password manager python tests in the password internals page tab (Closed)

Created:
6 years, 3 months ago by rchtara
Modified:
6 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Never run the password manager python tests in the password internals page tab This CL fixes that issue by always making sure that at the end of each test, the current tab is changed from the password internal page to the test page even if an exception is thrown. BUG=413273 Committed: https://crrev.com/2dbfd72d2ea1abdcf79ca012686251cb9d112858 Cr-Commit-Position: refs/heads/master@{#294831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -56 lines) Patch
M components/test/data/password_manager/websitetest.py View 4 chunks +64 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rchtara
Hi, Could you please review this cl? Thanks a lot Riadh
6 years, 3 months ago (2014-09-11 16:22:19 UTC) #2
vabr (Chromium)
LGTM, Thanks for fixing this! Vaclav
6 years, 3 months ago (2014-09-15 15:00:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562013003/1
6 years, 3 months ago (2014-09-15 15:01:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 602bba15e61d83077be5165bd6f3317a818400e1
6 years, 3 months ago (2014-09-15 16:08:13 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2dbfd72d2ea1abdcf79ca012686251cb9d112858 Cr-Commit-Position: refs/heads/master@{#294831}
6 years, 3 months ago (2014-09-15 16:13:23 UTC) #7
chromium-reviews
6 years, 3 months ago (2014-09-15 16:14:39 UTC) #8
Thanks a lot for the review
Riadh

On Mon, Sep 15, 2014 at 6:13 PM, <commit-bot@chromium.org> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/2dbfd72d2ea1abdcf79ca012686251cb9d112858
> Cr-Commit-Position: refs/heads/master@{#294831}
>
> https://codereview.chromium.org/562013003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698