Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 561933004: 10.6 SDK compatibility (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

10.6 SDK compatibility. TEST=util_test MachOImageReader.* (and all others with a 10.6 SDK build) R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ab4978b51eb7c8dd280eb17bdd17f5a7811467bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -591 lines) Patch
M compat/compat.gyp View 2 chunks +28 lines, -11 lines 0 comments Download
A compat/mac/mach-o/getsect.h View 1 chunk +69 lines, -0 lines 0 comments Download
A compat/mac/mach-o/getsect.cc View 1 chunk +107 lines, -0 lines 0 comments Download
M third_party/apple_cctools/README.crashpad View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/apple_cctools/apple_cctools.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/apple_cctools/cctools/include/mach-o/getsect.h View 3 chunks +14 lines, -81 lines 0 comments Download
M third_party/apple_cctools/cctools/libmacho/getsecbyname.c View 6 chunks +34 lines, -498 lines 0 comments Download
M util/mac/mach_o_image_reader_test.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M util/test/mac/dyld.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-11 21:16:30 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-12 14:28:58 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-12 16:13:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as ab4978b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698