Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 56193006: ui/gfx: Remove gmock usage from animation_container_unittest.cc. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

ui/gfx: Remove gmock usage from animation_container_unittest.cc. Rewrite part of the test using plain C++ Fake pattern. BUG=134675 TEST=ui_unittests --gtest_filter=AnimationContainerTest.* R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M ui/gfx/animation/animation_container_unittest.cc View 4 chunks +26 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
7 years, 1 month ago (2013-11-02 03:57:19 UTC) #1
tfarina
ping?
7 years, 1 month ago (2013-11-04 23:57:37 UTC) #2
tfarina
Hi Scott, do you have cycles to review this to me? Thanks,
7 years, 1 month ago (2013-11-05 13:09:26 UTC) #3
sky
LGTM
7 years, 1 month ago (2013-11-05 16:33:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/56193006/1
7 years, 1 month ago (2013-11-05 21:23:59 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 23:30:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/56193006/1
7 years, 1 month ago (2013-11-05 23:54:04 UTC) #7
commit-bot: I haz the power
Change committed as 233168
7 years, 1 month ago (2013-11-06 01:04:30 UTC) #8
Ben Goodger (Google)
7 years, 1 month ago (2013-11-06 20:19:48 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698