Issue 561923002: Revert of Add logspam to help diagnose flaky tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 561923002: Revert of Add logspam to help diagnose flaky tests (Closed)

Created:
6 years, 3 months ago by David Tseng

Modified:
6 years, 3 months ago

Reviewers:
aboxhall, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of Add logspam to help diagnose flaky tests (patchset #2 id:20001 of https://codereview.chromium.org/485843002/) Reason for revert: No longer needed since AutomationApiTests have been running for some time without flaking. Original issue's description: > Add logspam to help diagnose flaky tests > > BUG=391279, 385701, 353039, 379927, 384673 TBR=kalman@chromium.org,aboxhall@chromium.org NOTREECHECKS=true NOTRY=true BUG=391279, 385701, 353039, 379927, 384673 Committed: https://crrev.com/64e5fad6fe4122f60afb674d8a2d0be7e0674c0e Cr-Commit-Position: refs/heads/master@{#294236}

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -31 lines)			Patch
M	chrome/browser/extensions/api/automation_internal/automation_util.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/renderer/resources/extensions/automation/automation_node.js	View	4 chunks	+3 lines, -10 lines	0 comments	Download
M	chrome/renderer/resources/extensions/automation_custom_bindings.js	View	5 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/automation/tests/tabs/common.js	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/automation/tests/tabs_automation_boolean/common.js	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

David Tseng

Created Revert of Add logspam to help diagnose flaky tests

6 years, 3 months ago (2014-09-10 21:40:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/561923002/1

6 years, 3 months ago (2014-09-10 21:42:00 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as a81e0b8dab871e73ad8ce55a504fad62799c31bf

6 years, 3 months ago (2014-09-10 21:49:37 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 22:00:16 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/64e5fad6fe4122f60afb674d8a2d0be7e0674c0e
Cr-Commit-Position: refs/heads/master@{#294236}