Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 561903002: Remove implicit conversions from scoped_refptr to T* in c/b/ui/webui (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jshin+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in c/b/ui/webui This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Committed: https://crrev.com/e610c024fbb89133d8ac8a3b6756329aa2b77a28 Cr-Commit-Position: refs/heads/master@{#294628}

Patch Set 1 #

Patch Set 2 : Remove dumb change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/ui/webui/chromeos/login/authenticated_user_email_retriever.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/slow_trace_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-09-10 21:16:52 UTC) #2
arv (Not doing code reviews)
LGTM
6 years, 3 months ago (2014-09-12 16:16:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561903002/20001
6 years, 3 months ago (2014-09-12 17:04:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ffce63d0b2845bb51e2761043f9b0c2c231eaf49
6 years, 3 months ago (2014-09-12 19:20:10 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:23:30 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e610c024fbb89133d8ac8a3b6756329aa2b77a28
Cr-Commit-Position: refs/heads/master@{#294628}

Powered by Google App Engine
This is Rietveld 408576698