Hide location icon bubble on 2nd click.

Hide location icon bubble on 2nd click.

If location icon bubble is shown, then clicking on it again should
hide it. That is, it should toggle the popup on every click (press
and release).

BUG=107876
R=pkasting@chromium.org

TEST=
1) Navigate to any webpage so that page info is enabled.
2) Click on page info icon to show the popup.
2) When the popup is shown, click the icon again and observe.
3) 2nd click should close the popup instead of showing it again.

Committed: https://crrev.com/d40bf39a81bde583fd72f7c3729a40617a574661
Cr-Commit-Position: refs/heads/master@{#295413}

[Gaja, 2014-09-17 12:32:41]

@pkasting
Please take a look. Thanks.

[Peter Kasting, 2014-09-17 20:51:42]

LGTM

https://codereview.chromium.org/561883006/diff/1/chrome/browser/ui/views/loca...
File chrome/browser/ui/views/location_bar/location_icon_view.cc (right):

https://codereview.chromium.org/561883006/diff/1/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_icon_view.cc:38: return true;
Nit: I'd just eliminate both comments here.  I don't think they add much to the
code.

https://codereview.chromium.org/561883006/diff/1/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_icon_view.cc:44: // If this is the
second click on this view then the bubble was showing on
Nit: Blank line above this

https://codereview.chromium.org/561883006/diff/1/chrome/browser/ui/views/loca...
File chrome/browser/ui/views/location_bar/location_icon_view.h (right):

https://codereview.chromium.org/561883006/diff/1/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_icon_view.h:41: // ignored to
prevent the bubble from reshowing.
Nit: How about this:

Set to true when the bubble is already showing at the time the icon is clicked. 
This suppresses re-showing the bubble on mouse release, so that clicking the
icon repeatedly will appear to toggle the bubble on and off.

[Gaja, 2014-09-18 02:51:39]

Addressed nits in Patch Set #2. Checking commit.

https://chromiumcodereview.appspot.com/561883006/diff/1/chrome/browser/ui/vie...
File chrome/browser/ui/views/location_bar/location_icon_view.cc (right):

https://chromiumcodereview.appspot.com/561883006/diff/1/chrome/browser/ui/vie...
chrome/browser/ui/views/location_bar/location_icon_view.cc:38: return true;
On 2014/09/17 20:51:42, Peter Kasting wrote:
> Nit: I'd just eliminate both comments here.  I don't think they add much to
the
> code.

Done.

https://chromiumcodereview.appspot.com/561883006/diff/1/chrome/browser/ui/vie...
chrome/browser/ui/views/location_bar/location_icon_view.cc:44: // If this is the
second click on this view then the bubble was showing on
On 2014/09/17 20:51:42, Peter Kasting wrote:
> Nit: Blank line above this

Done.

https://chromiumcodereview.appspot.com/561883006/diff/1/chrome/browser/ui/vie...
File chrome/browser/ui/views/location_bar/location_icon_view.h (right):

https://chromiumcodereview.appspot.com/561883006/diff/1/chrome/browser/ui/vie...
chrome/browser/ui/views/location_bar/location_icon_view.h:41: // ignored to
prevent the bubble from reshowing.
On 2014/09/17 20:51:42, Peter Kasting wrote:
> Nit: How about this:
> 
> Set to true when the bubble is already showing at the time the icon is
clicked. 
> This suppresses re-showing the bubble on mouse release, so that clicking the
> icon repeatedly will appear to toggle the bubble on and off.

Perfect. Thanks!.

[Gaja, 2014-09-18 02:52:23]

The CQ bit was checked by gajendra.n@samsung.com

[commit-bot: I haz the power, 2014-09-18 02:52:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/561883006/20001

[commit-bot: I haz the power, 2014-09-18 04:03:40]

Committed patchset #2 (id:20001) as 3faf85e55c38d9ca092d8b45a7b582ca81e017b5

[commit-bot: I haz the power, 2014-09-18 04:10:13]

Patchset 2 (id:??) landed as
https://crrev.com/d40bf39a81bde583fd72f7c3729a40617a574661
Cr-Commit-Position: refs/heads/master@{#295413}