Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 561883003: Trace frame_time for SendBeginFrame (Closed)

Created:
6 years, 3 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 3 months ago
Reviewers:
no sievers, Sami
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Trace frame_time for SendBeginFrame It is useful for linking the BeginFrame sent from browser side and the BeginFrame received in renderer side. Often, the BeginFrame IPC message gets delayed and it becomes hard to track the BeginFrame received in renderer side is from which browser VSync. By dumping the frame_time, we can then do the cross-reference. BUG=406112 TEST=RenderWidgetHostViewAndroid::SendBeginFrame now shows frame_time. Committed: https://crrev.com/77ca6c1d24d114ab5d595bed0a14aa3ecdacac33 Cr-Commit-Position: refs/heads/master@{#294260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yufeng Shen (Slow to review)
6 years, 3 months ago (2014-09-10 21:53:45 UTC) #2
no sievers
lgtm
6 years, 3 months ago (2014-09-10 22:02:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/561883003/1
6 years, 3 months ago (2014-09-10 22:04:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 593bfbe2b6022e1da4a41544493f8000afc693dc
6 years, 3 months ago (2014-09-10 23:43:15 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 23:53:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77ca6c1d24d114ab5d595bed0a14aa3ecdacac33
Cr-Commit-Position: refs/heads/master@{#294260}

Powered by Google App Engine
This is Rietveld 408576698