Add load and store instructions to Subzero bitcode reader.

Add load and store instructions to Subzero bitcode reader.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3892
R=jvoung@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=41689df

[Karl, 2014-09-10 19:49:44]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2014-09-10 20:27:15]

otherwise LGTM

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:860: // name of the instruction the alignment appears
in.
Document that it returns true on success?

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:1024: // Checks if loading/storing wa value of type Ty,
is allowed for
wa --> a
also, no comma

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:1605: // TODO(kschimpf) Remove error recovery once
implementation complete.
Can this TODO be removed now?  Or does it belong inside extractAlignment()?

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:1620: if (!extractAlignment("Store", Values[1],
Alignment)) {
"Load"

[jvoung (off chromium), 2014-09-10 21:12:19]

lgtm too

[Karl, 2014-09-10 21:36:18]

Committed patchset #3 (id:40001) manually as 41689df (presubmit successful).

[Karl, 2014-09-10 21:36:29]

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:860: // name of the instruction the alignment appears
in.
On 2014/09/10 20:27:15, stichnot wrote:
> Document that it returns true on success?

Modified to always error recover, even on error, since 1 is always a valid
alignment.

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:1024: // Checks if loading/storing wa value of type Ty,
is allowed for
On 2014/09/10 20:27:15, stichnot wrote:
> wa --> a
> also, no comma

Done.

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:1605: // TODO(kschimpf) Remove error recovery once
implementation complete.
On 2014/09/10 20:27:15, stichnot wrote:
> Can this TODO be removed now?  Or does it belong inside extractAlignment()?

Modified so that the error recovery done inside extractAlignment.

https://codereview.chromium.org/561883002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:1620: if (!extractAlignment("Store", Values[1],
Alignment)) {
On 2014/09/10 20:27:15, stichnot wrote:
> "Load"

Done.