Issue 561873004: closure_linter: temporarily add support for @suppress {suspiciousCode} to unblock compiling setting…

Issue 561873004: closure_linter: temporarily add support for @suppress {suspiciousCode} to unblock compiling setting… (Closed)

Created:
6 years, 3 months ago by Dan Beam

Modified:
6 years, 3 months ago

Reviewers:
Vitaly Pavlenko, Tyler Breisacher (Chromium)

CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

closure_linter: temporarily add support for @suppress {suspiciousCode} to unblock compiling settings. R=vitalyp@chromium.org TBR=tbreisacher@chromium.org BUG=393873 NOTRY=true Committed: https://crrev.com/398a3834e5e6146a06239ffc4bfc80805f6481ee Cr-Commit-Position: refs/heads/master@{#294337}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	third_party/closure_linter/README.chromium	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	third_party/closure_linter/closure_linter/statetracker.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

Tyler Breisacher (Chromium)

I'm pretty sure doing an external push is not really on anyone's todo list at ...

6 years, 3 months ago (2014-09-11 04:18:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561873004/1

6 years, 3 months ago (2014-09-11 04:18:49 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 57407270be20af4f14fe34d14b9877ca88f1f7bb

6 years, 3 months ago (2014-09-11 06:16:53 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-11 06:19:07 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/398a3834e5e6146a06239ffc4bfc80805f6481ee
Cr-Commit-Position: refs/heads/master@{#294337}