Keep the wrench menu open after dragging an extension to the overflow menu

Keep the wrench menu open after dragging an extension to the overflow menu

Keep the wrench menu open for 300ms after dropping an extension action in it
to provide the user with visual feedback that the extension was properly moved.

BUG=412861
Committed: https://crrev.com/9f6ce019e67cbc47f67b0fce80c89a65ac25294d
Cr-Commit-Position: refs/heads/master@{#294605}

[Devlin, 2014-09-10 23:14:25]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Finnur, 2014-09-11 09:14:16]

LGTM

[Devlin, 2014-09-11 17:51:58]

rdevlin.cronin@chromium.org changed reviewers:
+ pkasting@chromium.org

[Devlin, 2014-09-11 17:51:58]

+Peter for OWNERS.

[Peter Kasting, 2014-09-11 20:24:39]

https://codereview.chromium.org/561833003/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (right):

https://codereview.chromium.org/561833003/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:19: const int
kCloseMenuDelay = 300;
Nit: Define constants like this in the most local scope possible.

https://codereview.chromium.org/561833003/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:65:
base::Bind(&ExtensionToolbarMenuView::CloseWrenchMenu,
Why not just leave the wrench menu open?  If I dragged something onto the button
to open the menu and then dropped it in the menu somewhere, I'd expect the menu
to still be open.  Or is that not how this flow happens?

[Devlin, 2014-09-11 21:00:54]

https://codereview.chromium.org/561833003/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (right):

https://codereview.chromium.org/561833003/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:19: const int
kCloseMenuDelay = 300;
On 2014/09/11 20:24:39, Peter Kasting wrote:
> Nit: Define constants like this in the most local scope possible.

Done.

https://codereview.chromium.org/561833003/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:65:
base::Bind(&ExtensionToolbarMenuView::CloseWrenchMenu,
On 2014/09/11 20:24:39, Peter Kasting wrote:
> Why not just leave the wrench menu open?  If I dragged something onto the
button
> to open the menu and then dropped it in the menu somewhere, I'd expect the
menu
> to still be open.  Or is that not how this flow happens?

The strict rule we agreed to with the UI designers was "If the menu is opened by
a direct click, leave it open. Otherwise, close it".  So, if you drag an item
from the main bar to the overflow, the menu is opened only because of the drag,
and chrome should close it.  (Depending on how people react, we may need to
change this - but for now, it's where we want to start.)

[Peter Kasting, 2014-09-11 21:02:24]

OK.  I dunno whether I think that's great, but it's a good enough argument to
start with.  LGTM

[Devlin, 2014-09-12 15:37:18]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-09-12 15:40:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/561833003/40001

[commit-bot: I haz the power, 2014-09-12 16:55:29]

Committed patchset #3 (id:40001) as 820504fde91c1b994bcf2404faf304f354c42776

[commit-bot: I haz the power, 2014-09-12 17:09:18]

Patchset 3 (id:??) landed as
https://crrev.com/9f6ce019e67cbc47f67b0fce80c89a65ac25294d
Cr-Commit-Position: refs/heads/master@{#294605}