Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: pkg/docgen/bin/upload_docgen.py

Issue 56183003: Refactor scripts, so we have a single entrypoint, dartdoc.py, to generate docs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/docgen/bin/upload_docgen.py
diff --git a/pkg/docgen/bin/upload_docgen.py b/pkg/docgen/bin/upload_docgen.py
index 6a3ea088324ebdf2aa71ad147f4d30d9b1ae8267..b59839451b8e216aae7d890081d1c4c40c83e5c2 100644
--- a/pkg/docgen/bin/upload_docgen.py
+++ b/pkg/docgen/bin/upload_docgen.py
@@ -4,13 +4,13 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
-""" This file will run docgen.dart on the SDK libraries, and upload them to
- Google Cloud Storage for the documentation viewer.
+""" This file will run docgen.dart on the SDK libraries, and upload them to
+ Google Cloud Storage for the documentation viewer.
"""
import optparse
import os
-from os.path import join, dirname, abspath, exists
+from os.path import join, dirname, abspath, exists
import platform
import subprocess
import sys
@@ -19,18 +19,18 @@ import utils
from upload_sdk import ExecuteCommand
-DART = abspath(join(dirname(__file__), '../../../%s/%s/dart-sdk/bin/dart'
- % (utils.BUILD_ROOT[utils.GuessOS()], utils.GetBuildConf('release',
+DART = abspath(join(dirname(__file__), '../../../%s/%s/dart-sdk/bin/dart'
+ % (utils.BUILD_ROOT[utils.GuessOS()], utils.GetBuildConf('release',
utils.GuessArchitecture()))))
-PACKAGE_ROOT = abspath(join(dirname(__file__), '../../../%s/%s/packages/'
- % (utils.BUILD_ROOT[utils.GuessOS()], utils.GetBuildConf('release',
+PACKAGE_ROOT = abspath(join(dirname(__file__), '../../../%s/%s/packages/'
+ % (utils.BUILD_ROOT[utils.GuessOS()], utils.GetBuildConf('release',
utils.GuessArchitecture()))))
GSUTIL = utils.GetBuildbotGSUtilPath()
GS_SITE = 'gs://dartlang-docgen'
DESCRIPTION='Runs docgen.dart on the SDK libraries, and uploads them to Google \
Cloud Storage for the dartdoc-viewer. '
# Allow us to override checking SVN's revision number. Useful for development
-# so we can upload docs from a branch using an SDK that was built on a
+# so we can upload docs from a branch using an SDK that was built on a
# revision newer than when the branch was forked.
trustSVN = None
@@ -49,14 +49,14 @@ def GetOptions():
def SetPackageRoot(path):
global PACKAGE_ROOT
if exists(path):
- PACKAGE_ROOT = abspath(path)
+ PACKAGE_ROOT = abspath(path)
def SetGsutil():
""" If not on buildbots, find gsutil relative to docgen. """
global GSUTIL
if not exists(GSUTIL):
- GSUTIL = abspath(join(dirname(__file__),
+ GSUTIL = abspath(join(dirname(__file__),
'../../../third_party/gsutil/gsutil'))
@@ -73,42 +73,42 @@ def main():
SetGsutil()
# Execute Docgen.dart on the SDK.
- ExecuteCommand(['sh', './generate_all_docs.sh'])
-
+ ExecuteCommand(['python', 'dartdoc.py', '-d'])
+
# Use SVN Revision to get the revision number.
revision = None
if trustSVN:
revision = utils.GetSVNRevision()
if revision is None:
- # Try to find the version from the dart-sdk folder.
- revision_file_location = abspath(join(dirname(__file__),
+ # Try to find the version from the dart-sdk folder.
+ revision_file_location = abspath(join(dirname(__file__),
'../../../%s/%s/dart-sdk/revision' % (utils.BUILD_ROOT[utils.GuessOS()],
utils.GetBuildConf('release', utils.GuessArchitecture()))))
with open(revision_file_location, 'r') as revision_file:
revision = revision_file.readline(5)
revision_file.close()
-
+
if revision is None:
raise Exception("Unable to find revision. ")
- # Upload the all files in Docs into a folder based off Revision number on
+ # Upload the all files in Docs into a folder based off Revision number on
# Cloud Storage.
- # TODO(alanknight): If we give it ./docs/* it fails to upload files in the
+ # TODO(alanknight): If we give it ./docs/* it fails to upload files in the
# subdirectory, probably due to escaping. Work around it by changing dir.
- # Better, generalize this to be less dependent on the working directory.
+ # Better, generalize this to be less dependent on the working directory.
os.chdir('docs')
Upload('.', GS_SITE + '/' + revision + '/')
os.chdir('..')
- # Update VERSION file in Cloud Storage.
+ # Update VERSION file in Cloud Storage.
with open('VERSION', 'w') as version_file:
version_file.write(revision)
version_file.close()
Upload('./VERSION', GS_SITE + '/VERSION')
Upload('./VERSION', GS_SITE + '/' + revision + '/' + 'VERSION')
- # Clean up the files it creates.
+ # Clean up the files it creates.
ExecuteCommand(['rm', '-rf', './docs'])
ExecuteCommand(['rm', '-f', './VERSION'])

Powered by Google App Engine
This is Rietveld 408576698