Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1785)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 561813003: Prepare blink to unify definitions of load completion (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add document.close() to scroll-left-while-loading.html Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/ActivityLoggerTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index d72a9e8c724bfed1f84c8e2a8b38f50ba4ca57bb..475e975a426182f0245fc01c62de28632c9dc9e2 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -5328,7 +5328,7 @@ TEST_F(WebFrameTest, DidWriteToInitialDocumentBeforeModalDialog)
// initial empty document state of the state machine. We normally set a
// timer to notify the client.
newView->mainFrame()->executeScript(
- WebScriptSource("window.opener.document.write('Modified');"));
+ WebScriptSource("window.opener.document.write('Modified'); window.opener.document.close();"));
EXPECT_FALSE(webFrameClient.m_didAccessInitialDocument);
// Make sure that a modal dialog forces us to notify right away.
« no previous file with comments | « Source/web/tests/ActivityLoggerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698