LayoutTests/editing/execCommand/window-open-insert-list-crash.html - Issue 561813003: Prepare blink to unify definitions of load completion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/window-open-insert-list-crash.html

Issue 561813003: Prepare blink to unify definitions of load completion (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/css3/masking/mask-repeat-space-padding-expected.html ('k') | LayoutTests/editing/undo/crash-redo-with-iframes.html » ('j') | LayoutTests/fast/dom/ImageDocument-image-deletion-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Crash issue 338542</title>	4 <title>Crash issue 338542</title>

5 <script src="../../resources/js-test.js"></script>	5 <script src="../../resources/js-test.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <script>	8 <script>

9 description('Should not crash if we load a test case from crbug.com/338542.');	9 description('Should not crash if we load a test case from crbug.com/338542.');

10	10

11 window.jsTestIsAsync = true;	11 window.jsTestIsAsync = true;

12	12

13 window.addEventListener('message', didReceiveMessage, false);	13 window.addEventListener('message', didReceiveMessage, false);

14	14

15 var iframe = document.createElement('iframe');	15 var iframe = document.createElement('iframe');

16 iframe.src = 'resources/window-open-insert-list-crash-iframe.html';	16 iframe.src = 'resources/window-open-insert-list-crash-iframe.html';

17 document.body.appendChild(iframe);	17 document.body.appendChild(iframe);

18	18

19 function didReceiveMessage(event)	19 function didReceiveMessage(event)

20 {	20 {

	21 if (iframe === null)

	22 return;

21 shouldBeEqualToString('event.data', 'FINISH');	23 shouldBeEqualToString('event.data', 'FINISH');

22 document.body.removeChild(iframe);	24 document.body.removeChild(iframe);

	25 iframe = null;
	dcheng 2014/10/20 18:35:14 Why is it important that this code only runs once Why is it important that this code only runs once now?
23 testPassed('Did not crash.');	26 testPassed('Did not crash.');

24 window.finishJSTest();	27 window.finishJSTest();

25 }	28 }

26 </script>	29 </script>

27 </body>	30 </body>

28 </html>	31 </html>

OLD	NEW