Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: chrome/browser/notifications/notification.h

Issue 561813002: Move the logic for creating data: URLs out of DesktopNotificationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification.h
diff --git a/chrome/browser/notifications/notification.h b/chrome/browser/notifications/notification.h
index d2a9d4aef8e87316a2a2fc024375e650899c5864..9390ca2fff136ead8346201b4b10f2387367b1fd 100644
--- a/chrome/browser/notifications/notification.h
+++ b/chrome/browser/notifications/notification.h
@@ -13,11 +13,14 @@
#include "base/values.h"
#include "chrome/browser/notifications/notification_delegate.h"
#include "third_party/WebKit/public/web/WebTextDirection.h"
-#include "ui/gfx/image/image.h"
#include "ui/message_center/notification.h"
#include "ui/message_center/notification_types.h"
#include "url/gurl.h"
+namespace gfx {
+class Image;
+}
+
// Representation of a notification to be shown to the user.
// On non-Ash platforms these are rendered as HTML, sometimes described by a
// data url converted from text + icon data. On Ash they are rendered as
@@ -63,9 +66,6 @@ class Notification : public message_center::Notification {
virtual ~Notification();
Notification& operator=(const Notification& notification);
- // The URL (may be data:) containing the contents for the notification.
- const GURL& content_url() const { return content_url_; }
-
// The origin URL of the script which requested the notification.
const GURL& origin_url() const { return origin_url_; }
@@ -101,10 +101,6 @@ class Notification : public message_center::Notification {
// to have a non NULL RenderViewHost.
GURL icon_url_;
- // The URL of the HTML content of the toast (may be a data: URL for simple
- // string-based notifications).
- GURL content_url_;
-
// The URLs of the button images for a rich notification.
GURL button_one_icon_url_;
GURL button_two_icon_url_;
« no previous file with comments | « chrome/browser/notifications/desktop_notification_service_factory.cc ('k') | chrome/browser/notifications/notification.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698