Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: chrome/browser/notifications/notification.cc

Issue 561813002: Move the logic for creating data: URLs out of DesktopNotificationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/notification.h ('k') | chrome/test/base/testing_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification.cc
diff --git a/chrome/browser/notifications/notification.cc b/chrome/browser/notifications/notification.cc
index 7fcf601f2b7726165830679bce058058ef7688ff..bb926392b106fee080ee40d0582c31c2069a7394 100644
--- a/chrome/browser/notifications/notification.cc
+++ b/chrome/browser/notifications/notification.cc
@@ -4,10 +4,6 @@
#include "chrome/browser/notifications/notification.h"
-#include "base/strings/string_util.h"
-#include "chrome/browser/notifications/desktop_notification_service.h"
-#include "ui/base/webui/web_ui_util.h"
-
Notification::Notification(const GURL& origin_url,
const GURL& icon_url,
const base::string16& title,
@@ -28,11 +24,7 @@ Notification::Notification(const GURL& origin_url,
origin_url_(origin_url),
icon_url_(icon_url),
replace_id_(replace_id),
- delegate_(delegate) {
- // "Upconvert" the string parameters to a data: URL.
- content_url_ = GURL(DesktopNotificationService::CreateDataUrl(
- icon_url, title, body, dir));
-}
+ delegate_(delegate) {}
Notification::Notification(
message_center::NotificationType type,
@@ -87,7 +79,6 @@ Notification::Notification(const Notification& notification)
: message_center::Notification(notification),
origin_url_(notification.origin_url()),
icon_url_(notification.icon_url()),
- content_url_(notification.content_url()),
button_one_icon_url_(notification.button_one_icon_url()),
button_two_icon_url_(notification.button_two_icon_url()),
image_url_(notification.image_url()),
@@ -100,7 +91,6 @@ Notification& Notification::operator=(const Notification& notification) {
message_center::Notification::operator=(notification);
origin_url_ = notification.origin_url();
icon_url_ = notification.icon_url();
- content_url_ = notification.content_url();
button_one_icon_url_ = notification.button_one_icon_url();
button_two_icon_url_ = notification.button_two_icon_url();
image_url_ = notification.image_url();
« no previous file with comments | « chrome/browser/notifications/notification.h ('k') | chrome/test/base/testing_profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698