Move the logic for creating data: URLs out of DesktopNotificationService.

Move the logic for creating data: URLs out of DesktopNotificationService.

This code is only used by the Notification constructor, and doesn't have
to be a public method on a class that's otherwise unrelated to it.

Also get rid of caching the UI manager in the service. All callsites of
the constructor passed in NULL, and BrowserProcess::notification_ui_manager()
actually does the caching for us.

TBR=jochen
BUG=

Committed: https://crrev.com/b1f28c8f2c486bf5891a56dd3af00fe93b0a30d3
Cr-Commit-Position: refs/heads/master@{#294414}

[Peter Beverloo, 2014-09-10 17:06:08]

peter@chromium.org changed reviewers:
+ dewittj@chromium.org, mukai@chromium.org

[Peter Beverloo, 2014-09-10 17:06:09]

Let's start shaving bits off DNS before splitting off a permission class.

The entire text-to-data-URL stuff is dirty. The actual fix here is to only
create a Notification object when we have requested |icon_url|, but I need to
think some more about how we're going to do that without a WebContents
(notifications from workers).

[Jun Mukai, 2014-09-10 18:18:59]

https://codereview.chromium.org/561813002/diff/1/chrome/browser/notifications...
File chrome/browser/notifications/notification.cc (right):

https://codereview.chromium.org/561813002/diff/1/chrome/browser/notifications...
chrome/browser/notifications/notification.cc:9: #include
"chrome/browser/notifications/desktop_notification_service.h"
You can remove this include right?

https://codereview.chromium.org/561813002/diff/20001/chrome/browser/notificat...
File chrome/browser/notifications/notification.cc (right):

https://codereview.chromium.org/561813002/diff/20001/chrome/browser/notificat...
chrome/browser/notifications/notification.cc:90: content_url_ =
GURL(CreateDataUrlForNotificationData(
actually, content_url_ itself is a deprecated thing, it's not used anymore. It
was used in old balloon notifications, but we've forgotten to remove this field
when removing the balloon code.

Could you remove this field and CraeteDataUrlForNotificationData itself?

[Peter Beverloo, 2014-09-11 16:02:26]

https://codereview.chromium.org/561813002/diff/1/chrome/browser/notifications...
File chrome/browser/notifications/notification.cc (right):

https://codereview.chromium.org/561813002/diff/1/chrome/browser/notifications...
chrome/browser/notifications/notification.cc:9: #include
"chrome/browser/notifications/desktop_notification_service.h"
On 2014/09/10 18:18:59, Jun Mukai wrote:
> You can remove this include right?

Done.

https://codereview.chromium.org/561813002/diff/20001/chrome/browser/notificat...
File chrome/browser/notifications/notification.cc (right):

https://codereview.chromium.org/561813002/diff/20001/chrome/browser/notificat...
chrome/browser/notifications/notification.cc:90: content_url_ =
GURL(CreateDataUrlForNotificationData(
On 2014/09/10 18:18:59, Jun Mukai wrote:
> actually, content_url_ itself is a deprecated thing, it's not used anymore. It
> was used in old balloon notifications, but we've forgotten to remove this
field
> when removing the balloon code.
> 
> Could you remove this field and CraeteDataUrlForNotificationData itself?

Yay! Done.

[Jun Mukai, 2014-09-11 16:36:38]

lgtm!!

[dewittj, 2014-09-11 16:40:08]

lgtm

[Peter Beverloo, 2014-09-11 16:53:03]

peter@chromium.org changed reviewers:
+ jochen@chromium.org

[Peter Beverloo, 2014-09-11 16:53:03]

+jochen for chrome/test/. TBR'ing because it's removing an argument from testing
code, reviewed by OWNERS of the relevant feature.

[Peter Beverloo, 2014-09-11 16:53:23]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-09-11 16:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/561813002/40001

[commit-bot: I haz the power, 2014-09-11 17:40:22]

Committed patchset #3 (id:40001) as 90a2921899a5790bfd3861ea314f694905f729d5

[commit-bot: I haz the power, 2014-09-11 18:42:50]

Patchset 3 (id:??) landed as
https://crrev.com/b1f28c8f2c486bf5891a56dd3af00fe93b0a30d3
Cr-Commit-Position: refs/heads/master@{#294414}