Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 561763002: disable conservative rasterclip on gpu, until we understand perspective (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years ago
CC:
reviews_skia.org, fmalita_google_do_not_use
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

disable conservative rasterclip on gpu, until we understand perspective BUG=skia: Committed: https://skia.googlesource.com/skia/+/841010f4bd54663e41900359fd32640767e6c8cd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M include/gpu/SkGpuDevice.h View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 9 (3 generated)
reed1
6 years, 3 months ago (2014-09-10 14:09:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/561763002/1
6 years, 3 months ago (2014-09-10 14:10:51 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-10 14:10:52 UTC) #5
bsalomon
On 2014/09/10 14:10:52, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
6 years, 3 months ago (2014-09-10 14:20:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 841010f4bd54663e41900359fd32640767e6c8cd
6 years, 3 months ago (2014-09-10 14:23:39 UTC) #7
robertphillips
6 years ago (2014-12-02 13:26:46 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/561763002/diff/1/include/gpu/SkGpuDevice.h
File include/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/561763002/diff/1/include/gpu/SkGpuDevice.h#ne...
include/gpu/SkGpuDevice.h:155: 
In ToT Skia forceConservativeRasterClip returns true but this comment remains.

Powered by Google App Engine
This is Rietveld 408576698