Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: Source/core/inspector/PromiseTracker.h

Issue 561753002: Oilpan: fix PromiseTracker's handling of its persistent promise wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add FIXME on using DOMWrapperWorld to hold PromiseTrackerWrapper instances Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/PromiseTracker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PromiseTracker.h
diff --git a/Source/core/inspector/PromiseTracker.h b/Source/core/inspector/PromiseTracker.h
index 97bc2d479a0a85cfacc04bdd7d719bc55ebb1658..9bbdce9edc16c6db12f6241289e4e0e5ea6ecaad 100644
--- a/Source/core/inspector/PromiseTracker.h
+++ b/Source/core/inspector/PromiseTracker.h
@@ -17,12 +17,14 @@ namespace blink {
class ScriptState;
-class PromiseTracker FINAL {
+class PromiseTracker FINAL : public NoBaseWillBeGarbageCollected<PromiseTracker> {
WTF_MAKE_NONCOPYABLE(PromiseTracker);
- DISALLOW_ALLOCATION();
+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(PromiseTracker);
public:
- PromiseTracker();
- ~PromiseTracker();
+ static PassOwnPtrWillBeRawPtr<PromiseTracker> create()
+ {
+ return adoptPtrWillBeNoop(new PromiseTracker());
+ }
bool isEnabled() const { return m_isEnabled; }
void setEnabled(bool);
@@ -40,13 +42,17 @@ public:
void trace(Visitor*);
+ PromiseDataMap& promiseDataMap() { return m_promiseDataMap; }
+
private:
+ PromiseTracker();
+
int circularSequentialId();
PassRefPtrWillBeRawPtr<PromiseData> createPromiseDataIfNeeded(v8::Isolate*, v8::Handle<v8::Object> promise);
- bool m_isEnabled;
int m_circularSequentialId;
PromiseDataMap m_promiseDataMap;
+ bool m_isEnabled;
};
} // namespace blink
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/PromiseTracker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698