Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 561733004: Fixing path to chrome app samples in documentation (Closed)

Created:
6 years, 3 months ago by fgorski
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing path to chrome app samples in documentation BUG=412819 NOTRY=true Committed: https://crrev.com/c4d469ee57db15de353d6c3ce04c92b444f38f9b Cr-Commit-Position: refs/heads/master@{#294231}

Patch Set 1 #

Patch Set 2 : Adding app.yaml and cron.yaml vesion update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M chrome/common/extensions/docs/server2/app.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/url_constants.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/angular_framework.html View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_external.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_identity.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_intents.html View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_network.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_serial.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_storage.html View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_usb.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/cloudMessaging.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/cloudMessagingV2.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/first_app.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/google_wallet.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/inform_users.html View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/richNotifications.html View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/api/app_window.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
fgorski
Vincent, could you take a look or point me to a different reviewer? (With Kalman ...
6 years, 3 months ago (2014-09-10 16:49:38 UTC) #2
scheib
lgtm app.yaml should only need to be updated if changing code - these content changes ...
6 years, 3 months ago (2014-09-10 17:50:43 UTC) #3
scheib
On 2014/09/10 17:50:43, scheib wrote: > lgtm > > app.yaml should only need to be ...
6 years, 3 months ago (2014-09-10 17:52:27 UTC) #6
fgorski
I've updated version for app.yaml and cron.yaml
6 years, 3 months ago (2014-09-10 21:09:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/561733004/20001
6 years, 3 months ago (2014-09-10 21:12:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as eeadc6241eb92dcb9ba1e15f8131fe89f61e6b5b
6 years, 3 months ago (2014-09-10 21:15:21 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 21:25:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4d469ee57db15de353d6c3ce04c92b444f38f9b
Cr-Commit-Position: refs/heads/master@{#294231}

Powered by Google App Engine
This is Rietveld 408576698