Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 561693002: CSP: Resolve report endpoints at reporting time, not at parse time. (Closed)

Created:
6 years, 3 months ago by Mike West
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

CSP: Resolve report endpoints at reporting time, not at parse time. This patch moves the single call to ContentSecurityPolicy::completeURL up from CSPDirectiveList to ContentSecurityPolicy. We now resolve the URL when sending reports rather than resolving them during parsing. This allows us to parse a policy without already being bound to an execution context. BUG=411889 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181727

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/frame/csp/CSPDirectiveList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/csp/CSPDirectiveList.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mike West
Mind taking a look at this, Kenneth?
6 years, 3 months ago (2014-09-10 06:56:50 UTC) #2
Mike West
On 2014/09/10 06:56:50, Mike West wrote: > Mind taking a look at this, Kenneth? Rebased ...
6 years, 3 months ago (2014-09-10 08:20:24 UTC) #3
Mike West
Widening the reviewer net, as I don't see Kenneth on IRC today.
6 years, 3 months ago (2014-09-10 11:05:21 UTC) #5
philipj_slow
lgtm
6 years, 3 months ago (2014-09-10 11:12:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/561693002/20001
6 years, 3 months ago (2014-09-10 11:13:09 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 12:13:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181727

Powered by Google App Engine
This is Rietveld 408576698