Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 561633002: chromium-build-stats: show ninja_log in table format (Closed)

Created:
6 years, 3 months ago by ukai
Modified:
6 years, 3 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Project:
infra
Visibility:
Public.

Description

chromium-build-stats: show ninja_log in table format /ninja_log/<path>/table shows ninja_log in table format ordered by duration, so it is useful to find what is bottleneck in the build. top page provides form to redirect from gsuri shown in compile.py stdio to /ninja_log page. fixed Step.Restat to be int. It shows strange date on windows platform. BUG=405942 Committed: https://chromium.googlesource.com/infra/infra/+/85e3de32d8c314aa4174f9f726a05a0f3d158c7f

Patch Set 1 #

Patch Set 2 : use 303 instead of 302 #

Total comments: 2

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -55 lines) Patch
M appengine/chromium_build_stats/default/app.go View 1 1 chunk +31 lines, -3 lines 0 comments Download
M appengine/chromium_build_stats/default/ninja_log.go View 7 chunks +48 lines, -4 lines 0 comments Download
M appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go View 1 2 5 chunks +13 lines, -7 lines 0 comments Download
M appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog_test.go View 17 chunks +11 lines, -33 lines 0 comments Download
M appengine/chromium_build_stats/gopath/src/ninjalog/trace_test.go View 6 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ukai
6 years, 3 months ago (2014-09-10 05:30:44 UTC) #2
Paweł Hajdan Jr.
LGTM https://codereview.chromium.org/561633002/diff/20001/appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go File appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go (right): https://codereview.chromium.org/561633002/diff/20001/appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go#newcode24 appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go:24: // on POSIX, time_t is used, but on ...
6 years, 3 months ago (2014-09-11 09:12:45 UTC) #3
ukai
https://codereview.chromium.org/561633002/diff/20001/appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go File appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go (right): https://codereview.chromium.org/561633002/diff/20001/appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go#newcode24 appengine/chromium_build_stats/gopath/src/ninjalog/ninjalog.go:24: // on POSIX, time_t is used, but on Windows ...
6 years, 3 months ago (2014-09-11 15:59:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561633002/40001
6 years, 3 months ago (2014-09-11 19:32:56 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 19:34:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 85e3de32d8c314aa4174f9f726a05a0f3d158c7f

Powered by Google App Engine
This is Rietveld 408576698