Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 561623002: GN: Enable blink and (nearly) all of content in android build (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, sadrul, jam, jln+watch_chromium.org, darin-cc_chromium.org, ben+ash_chromium.org, kalyank, jochen+watch_chromium.org, cjhopman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Enable blink and (nearly) all of content in android build This enables all blink targets and nearly all content targets in the android build. This produces a content shell APK, but not a fully operational one yet. This also flips on a bunch of other targets pulled in by deps. R=brettw@chromium.org Committed: https://crrev.com/060f2e31fd19dd8d5b029cd281aed05a510c545f Cr-Commit-Position: refs/heads/master@{#294247}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -62 lines) Patch
M BUILD.gn View 5 chunks +5 lines, -11 lines 0 comments Download
M breakpad/BUILD.gn View 4 chunks +5 lines, -3 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M components/crash/app/BUILD.gn View 2 chunks +5 lines, -2 lines 0 comments Download
M content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 5 chunks +4 lines, -3 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +4 lines, -5 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +19 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/BUILD.gn View 6 chunks +12 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +9 lines, -1 line 0 comments Download
M sandbox/linux/BUILD.gn View 2 chunks +33 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
Excitement!
6 years, 3 months ago (2014-09-10 05:33:39 UTC) #1
brettw
yay lgtm
6 years, 3 months ago (2014-09-10 22:18:27 UTC) #2
jamesr
Committed patchset #2 (id:20001) to pending queue manually as 9fc8790.
6 years, 3 months ago (2014-09-10 22:38:59 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 22:49:14 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/060f2e31fd19dd8d5b029cd281aed05a510c545f
Cr-Commit-Position: refs/heads/master@{#294247}

Powered by Google App Engine
This is Rietveld 408576698