Issue 561533002: Add EventSourceInit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 561533002: Add EventSourceInit (Closed)

Created:
6 years, 3 months ago by bashi

Modified:
6 years, 3 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, arv+blink, eae+blinkwatch, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Add EventSourceInit The spec[1] says the EventSource constructor should take EventSourceInit dictionary as an argument. This CL doesn't change behavior. Tests under http/tests/eventsource cover this change. [1] http://www.w3.org/TR/eventsource/#eventsource BUG=403150 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181705

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/page/EventSource.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/page/EventSource.cpp	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	Source/core/page/EventSource.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	Source/core/page/EventSourceInit.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

bashi

Haraken-san, could you take a look when you have time? No-hurry.

6 years, 3 months ago (2014-09-10 04:24:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/561533002/1

6 years, 3 months ago (2014-09-10 04:30:15 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 06:32:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 181705