Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 561513003: Landing Recent QUIC Changes. (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, Ian Swett, rjshade, alyssar
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC Changes. Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always removing all old transmissions. When truncated acks start arriving, they don't stop until least_unacked is raised, which takes an entire RTT, so this is the eventual effect of all those truncated acks. Instead, remove all of them the first time. Merge internal change: 74881713 https://codereview.chromium.org/556103002/ Discard old packets from the QuicSentPacketManager which are only present for RTT purposes(typically acks) when the map exceeds 200 packets. Merge internal change: 74814618 https://codereview.chromium.org/551223002/ Fix a flaky QUIC end_to_end_test when the socket was suddenly unwritable and the connection closed, but CanWrite returned true. Merge internal change: 74798317 https://codereview.chromium.org/550703003/ Fix a crash bug in QuicUnackedPacketMap when truncated acks arrived. Merge internal change: 74792668 https://codereview.chromium.org/554993002/ Send an ack when it 20 packets have been received since the last ack was sent. This allows the peer to discard data from the SentPacketManager. Merge internal change: 74741188 https://codereview.chromium.org/555653002/ R=rch@chromium.org Committed: https://crrev.com/e970ae47a0490d1faafd7d6d1c7891a9c901266c Cr-Commit-Position: refs/heads/master@{#294295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -13 lines) Patch
M net/quic/quic_connection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 6 chunks +17 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 2 chunks +7 lines, -3 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 4 chunks +31 lines, -7 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 3 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ramant (doing other things)
6 years, 3 months ago (2014-09-10 00:41:25 UTC) #1
ramant (doing other things)
On 2014/09/10 00:41:25, ramant wrote: Hi Ryan, This CL and rjshade's CL merges all CL's ...
6 years, 3 months ago (2014-09-10 00:46:50 UTC) #2
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-09-10 15:45:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561513003/1
6 years, 3 months ago (2014-09-11 00:55:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3a8a87365c890464ce3f1de607370a88ec4a2a62
6 years, 3 months ago (2014-09-11 02:02:24 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 03:09:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e970ae47a0490d1faafd7d6d1c7891a9c901266c
Cr-Commit-Position: refs/heads/master@{#294295}

Powered by Google App Engine
This is Rietveld 408576698