Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 561503002: [DirectWrite] Set blink device scale factor (Closed)

Created:
6 years, 3 months ago by eae
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DirectWrite] Set blink device scale factor Change renderer_main_platform_delegate_win to set the device scale factor for the renderer in PlatformInitialize. The blink text rendering code requires on this value being set. Depends on Blink change https://codereview.chromium.org/553163002/ which must land and roll before this can be landed. R=cpu@chromium.org, creis@chromium.org Committed: https://crrev.com/56075d70b6eb92bf9ca3c0b90a07c92e97d80f88 Cr-Commit-Position: refs/heads/master@{#294397}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/renderer_main_platform_delegate_win.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
eae
6 years, 3 months ago (2014-09-09 23:25:18 UTC) #2
scottmg
lgtm
6 years, 3 months ago (2014-09-09 23:37:42 UTC) #4
eae
Thanks Scott! To unsubscribe from this group and stop receiving emails from it, send an ...
6 years, 3 months ago (2014-09-09 23:48:22 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-10 00:55:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/561503002/1
6 years, 3 months ago (2014-09-10 18:52:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10047)
6 years, 3 months ago (2014-09-10 19:18:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/561503002/1
6 years, 3 months ago (2014-09-10 21:01:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10085)
6 years, 3 months ago (2014-09-10 21:23:16 UTC) #14
eae
+ jam, creis for content/OWNERS
6 years, 3 months ago (2014-09-10 21:35:44 UTC) #16
Charlie Reis
Rubber stamp LGTM.
6 years, 3 months ago (2014-09-10 23:12:28 UTC) #17
eae
On 2014/09/10 23:12:28, Charlie Reis wrote: > Rubber stamp LGTM. Thanks!
6 years, 3 months ago (2014-09-10 23:13:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561503002/1
6 years, 3 months ago (2014-09-10 23:18:12 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/11212) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/8221)
6 years, 3 months ago (2014-09-11 01:22:13 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561503002/1
6 years, 3 months ago (2014-09-11 02:09:40 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/11329)
6 years, 3 months ago (2014-09-11 04:04:33 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561503002/20001
6 years, 3 months ago (2014-09-11 14:58:11 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9c6d6bc96d01428866148c1005c4c69cc6328e55
6 years, 3 months ago (2014-09-11 16:03:12 UTC) #30
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 16:11:05 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56075d70b6eb92bf9ca3c0b90a07c92e97d80f88
Cr-Commit-Position: refs/heads/master@{#294397}

Powered by Google App Engine
This is Rietveld 408576698