Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 561453004: Add RenderView ResetDeviceColorProfileForTesting (Closed)

Created:
6 years, 3 months ago by Noel Gordon
Modified:
6 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add RenderView ResetDeviceColorProfileForTesting Provide a method to reset the device color profile for tests, and make TestRunner call it prior to each layout test. This to reset the Page color profile to its default state, to let Page choose the default color profile, rather than TestRunner. BUG=369787, 368663 Committed: https://crrev.com/db4df1518ef3245e97addc44d52994253cfabbdf Cr-Commit-Position: refs/heads/master@{#295097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Noel Gordon
See http://crbug.com/412614 for the android bot failure.
6 years, 3 months ago (2014-09-15 04:15:14 UTC) #1
Noel Gordon
See http://crbug.com/412614 for the android bot failure.
6 years, 3 months ago (2014-09-15 04:16:31 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-16 15:46:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561453004/1
6 years, 3 months ago (2014-09-16 17:09:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 737ce5d2a15656b08618ccc8dcc4aad8b19d8b89
6 years, 3 months ago (2014-09-16 17:46:20 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 17:47:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db4df1518ef3245e97addc44d52994253cfabbdf
Cr-Commit-Position: refs/heads/master@{#295097}

Powered by Google App Engine
This is Rietveld 408576698