Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 561443002: Ouptut oldLocation and newLocation in trace of paint invalidation (Closed)

Created:
6 years, 3 months ago by Xianzhu
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink
Project:
blink
Visibility:
Public.

Description

Ouptut oldLocation and newLocation in trace of paint invalidation I found that InvalidationLocationChange is a very frequent invalidation reason for some repaint storms. The invalidation is because the location (from the paint invalidation container) of the render object changed since the last invalidation. It will be helpful to know how the location changes when debugging repaint storms. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M Source/core/rendering/RenderObject.cpp View 3 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Xianzhu
6 years, 3 months ago (2014-09-09 20:55:13 UTC) #2
Xianzhu
ping...
6 years, 3 months ago (2014-09-10 17:19:29 UTC) #3
pdr.
On 2014/09/10 17:19:29, Xianzhu wrote: > ping... LGTM
6 years, 3 months ago (2014-09-10 18:25:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/561443002/1
6 years, 3 months ago (2014-09-10 18:26:12 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 19:29:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181759

Powered by Google App Engine
This is Rietveld 408576698