chrome/browser/ui/toolbar/back_forward_menu_model.cc - Issue 56143002: Make FaviconService() use Porfile as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model.cc

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test but break the DEPS Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/back_forward_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model.cc b/chrome/browser/ui/toolbar/back_forward_menu_model.cc

index 9f26f693795ffaf53e89b679f6ab267f0e4f3d80..db4efe244c02302c2f8941984a93881f447c02cf 100644

--- a/chrome/browser/ui/toolbar/back_forward_menu_model.cc

+++ b/chrome/browser/ui/toolbar/back_forward_menu_model.cc

@@ -255,8 +255,7 @@ void BackForwardMenuModel::FetchFavicon(NavigationEntry* entry) {

return;

favicon_service->GetFaviconImageForURL(

- FaviconService::FaviconForURLParams(browser_->profile(),

- entry->GetURL(),

+ FaviconService::FaviconForURLParams(entry->GetURL(),

chrome::FAVICON,

gfx::kFaviconSize),

base::Bind(&BackForwardMenuModel::OnFavIconDataAvailable,