chrome/browser/ui/cocoa/history_menu_bridge.mm - Issue 56143002: Make FaviconService() use Porfile as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_bridge.mm

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test but break the DEPS Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/history_menu_bridge.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_bridge.mm b/chrome/browser/ui/cocoa/history_menu_bridge.mm

index a2cffbfa03b5ae994d61398e7deaf40fa915f26c..d206e8eade516ceba002944f72b0d785d04fe31a 100644

--- a/chrome/browser/ui/cocoa/history_menu_bridge.mm

+++ b/chrome/browser/ui/cocoa/history_menu_bridge.mm

@@ -459,8 +459,7 @@ void HistoryMenuBridge::GetFaviconForHistoryItem(HistoryItem* item) {

FaviconService* service =

FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);

CancelableTaskTracker::TaskId task_id = service->GetFaviconImageForURL(

- FaviconService::FaviconForURLParams(profile_,

- item->url,

+ FaviconService::FaviconForURLParams(item->url,

chrome::FAVICON,

gfx::kFaviconSize),

base::Bind(&HistoryMenuBridge::GotFaviconData,