chrome/browser/sync/glue/favicon_cache.cc - Issue 56143002: Make FaviconService() use Porfile as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/favicon_cache.cc

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test but break the DEPS Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/favicon_cache.cc

diff --git a/chrome/browser/sync/glue/favicon_cache.cc b/chrome/browser/sync/glue/favicon_cache.cc

index d6dcaa8be9f7f140814dab40529e3a121bcd4e45..f250d9b4c5c88f1a95c7e75f84f5a08994912748 100644

--- a/chrome/browser/sync/glue/favicon_cache.cc

+++ b/chrome/browser/sync/glue/favicon_cache.cc

@@ -468,8 +468,8 @@ void FaviconCache::OnPageFaviconUpdated(const GURL& page_url) {

// desired_size_in_dip). Figure out a way to fetch all favicons we support.

// See crbug.com/181068.

CancelableTaskTracker::TaskId id = favicon_service->GetFaviconForURL(

- FaviconService::FaviconForURLParams(

- profile_, page_url, SupportedFaviconTypes(), kMaxFaviconResolution),

+ FaviconService::FaviconForURLParams(page_url, SupportedFaviconTypes(),

+ kMaxFaviconResolution),

base::Bind(&FaviconCache::OnFaviconDataAvailable,

weak_ptr_factory_.GetWeakPtr(), page_url),

&cancelable_task_tracker_);